-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeSpec Repo Issue and PR orgranization #3265
Comments
related to #3157 |
@timotheeguerin is the suggestion here every issue has at least one label from |
I think it's fair to say almost every issue should have an area label and an impact label. Issues in the |
Yeah I agree I think every issue should get triaged into at least an area(maybe more) and have an impact(for most) |
Some comments
|
Simplfy flow from discussion in #3265 - Add `needs-author-feedback` manually -> this assign issue back to user - 14 days without reply close the issue - User reply remove `needs-author-feedback` and unassign user
Add script to sync labels to enforce the labels designed in #3265 <img width="1050" alt="image" src="https://github.com/microsoft/typespec/assets/1031227/5ba6a134-e6d6-4a28-9cf7-99fd27c8e89e">
We have a bit of a mess in our labels and pr naming is inconsitent/hard to review
Labels
Area labels
compiler:core
,compiler:emitter-framework
, etc.emitter:client:<lang>
emitter:service:<lang>
emitter:openapi
,emitter:grpc
, etc.lib:http
,lib:rest
,lib:openapi
,lib:tcgc
tspd
meta:website
,meta:blog
ide
,ide:vscode
,ide:vs
eng
General eng sys relevant to the entire repoKind labels
bug
,feature
,epic
,docs
Process label
needs-triage
- Automatically added on issue creationNeeds author feedback flow:
Current:
needs-author-feedback
- Someone needs to put this label explicitlyno-recent-activity
- after 1 weekneeds-team-attention
Added back if user replyProposed:
needs-author-feedback
- Someone needs to put this label explicitlyneeds-triage
addsneeds-triage
back if user replyDesign labels
design:needed
,design:proposed
,design:approved
Breaking change labels
breaking-change
,deprecation
Cleanup labels
Let's delete unused labels. Let's also delete low value labels if possible.
For example:
add-to-typespec-project
- do we need this label? If so, can we remove it automatically once the issue has been added?customer-reported
- is this valuable?client-emitter-migration
- temporary label during the migration we should remove and move remaining issue in the correct areaAPI Stewardship Board
- Not sure what this means?DPG Impact
- At the very least needs to be reworded to be useful for non-Azure to understand?Epic: xyz
Feel like we should use task list/sub issue or project for this insteadIssue & PR naming convention
Issue titles are just issue titles without metadata, so no prefixes, suffixes, or the like. Metadata exists in labels. This will ensure the smoothest possible experience with Chronus and other tooling, at the expense of slightly less useful commit descriptions.
Existing labels
Keep
Rename
documentation -> meta:docs
Client Emitter:
emitter:client:<lang>
->emitter:client:<lang>
enhancement -> feature
Design: Needed ->
design:needed
Design: Proposed ->
design:proposed
Design: Accepted ->
design:accepted
Service Codegen:
emitter:service:<lang>
->emitter:service:<lang>
IDE ->
ide
Epic ->
epic
gRPC ->
emitter:protobuf
Json Schema ->
emitter:json-schema
Infrastructure ->
eng
Contains Breaking Changes ->
breaking-change
Contains Deprecations ->
deprecation
add-to-typespec-project
->triaged:core
(can we remove after it gets added to the project, can we remove long term?)Client Emitter Migration ->
eng
oremitter:client:X
Remove
📌
Required for DPG 2.0
Post DPG 2.0
WS: Svc Partner Adoption
WS: External Developer Adoption
WS: Language Completeness
Epic: Cadl User Guide
Epic: Cadl language developer documentation
Epic: Change management & release process
Epic: Language verification & testing
Epic: Tooling help for decorators
Epic: Emitter Framework
Epic: Side-car
Epic: Projections to stable
Epic: Sub-typing
Epic: Refactor resource framework out of Rest lib
Epic: Unification of Templates etc
WS: Process Tools & Automation
WS: Code Generation
Epic: Cadl Metadata
duplicate
needs-team-attention
dependencies
help wanted
question
wontfix
Needs Estimate
Needs Triage
customer-reported
no-recent-activity
needs-customer-feedback
Graph Impact
DPG Impact
CLI/PSH Impact
Public Beta
OpenAI
Potential Breaking Changes
breaking-change-approved
MQ
API Stewardship Board
Figure if we can define this list in a file
Document labels, processes to
CONTRIBUTING.md
Issues:
PR:
Colors
compiler:* -- typespec brand color (dark purple)
lib:* -- light purple
ide:* -- mid purple
emitter:client:* -- light yellow
emitter:server:* -- dark yellow/gold
emitter:* -- mid yellow
eng: light blue (azure brand color)
meta: mid blue
tspd: dark blue
bug, feature, epic, docs -- light grey
needs-triage -- light red
triage-accepted -- grey
design:needed -- light green
design:proposed -- mid green
design:approved -- dark green
breaking-change: mid red
deprecation: dark red
The text was updated successfully, but these errors were encountered: