http-client-java, remove unused namer module #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changes needing a change description found. |
|
You can try these changes here
|
weidongxu-microsoft
requested review from
srnagar,
haolingdong-msft,
XiaofeiCao,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
haolingdong-msft
approved these changes
Sep 4, 2024
XiaofeiCao
approved these changes
Sep 4, 2024
weidongxu-microsoft
deleted the
http-client-java_remove-unused-module
branch
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
History: we originally intend to use m4 prenamer (opt-in via flag/option) to keep names in SDK same as from Swagger (mostly for brownfield). But later we decided to just use `@clientName` in client.tsp to explicitly do the naming, if backward-compatibility is an issue. This flag/option is not used by any service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History: we originally intend to use m4 prenamer (opt-in via flag/option) to keep names in SDK same as from Swagger (mostly for brownfield).
But later we decided to just use
@clientNamein client.tsp to explicitly do the naming, if backward-compatibility is an issue.This flag/option is not used by any service.