Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update decorator arg marshalling to new default #4500

Merged
merged 13 commits into from
Oct 5, 2024
Merged

Update decorator arg marshalling to new default #4500

merged 13 commits into from
Oct 5, 2024

Conversation

timotheeguerin
Copy link
Member

fix #4138

@microsoft-github-policy-service microsoft-github-policy-service bot added the compiler:core Issues for @typespec/compiler label Sep 23, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 23, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
  • ✅ @typespec/json-schema
Show changes

@typespec/compiler - breaking ✏️

API: Update default of decoratorArgMarshalling from legacy to new,> ,> To revert to the old behavior export the following. Highly discouraged, this will be removed in a few versions.,> ,> ts,> export const $flags = definePackageFlags({,> decoratorArgMarshalling: "legacy",,> });,>

@typespec/json-schema - internal ✏️

Update decorator arg marshalling to new default

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin added this pull request to the merge queue Oct 5, 2024
Merged via the queue into microsoft:main with commit aa189c6 Oct 5, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the decorator-arg-marshalling-new-default branch October 5, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
compiler:core Issues for @typespec/compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch decoratorArgMarshalling flags to new system by default
3 participants
@timotheeguerin @azure-sdk @chrisradek