-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[urho3d, xcb-util-wm] Hash fixes #29383
Conversation
Detected in https://dev.azure.com/vcpkg/public/_build/results?buildId=84431 The change appears to be changing some of the cases of filenames from uppercase to lowercase; possibly in response to one of the CVEs in Git when applied to case-insensitive filesystems.
That SHA512 is for 24eb17df2e1245885e72c9d4bbb0a0f69f0700f2, which was 0.4.1, not 0c6681e465c9cc7b1fbb60778ba1eaa61ab01a14 which is 0.4.2. This was probably just done wrong originally in microsoft#27240
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
vcpkg_extract_source_archive_ex
-> vcpkg_extract_source_archive
vcpkg_build_msbuild
-> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies
-> vcpkg_copy_tools
vcpkg_apply_patches
should be replaced by the PATCHES
arguments to the "extract" helpers (e.g. vcpkg_from_github()
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/stx/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/stx/vcpkg.json
ports/urho3d/vcpkg.json
Valid values for the license field can be found in the documentation
I see the patch failed. I suppose it’s quite different. |
It looks like the patch application for the stx port failed:
|
I've updated the port #29392 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/urho3d/vcpkg.json
Valid values for the license field can be found in the documentation
All these problems were detected in https://dev.azure.com/vcpkg/public/_build/results?buildId=84431 because the SAS token to our asset cache expired 😳
[Urho3D] Fix download hash.
The change appears to be changing some of the cases of filenames from uppercase to lowercase; possibly in response to one of the CVEs in Git when applied to case-insensitive filesystems.
[xcb-util-wm] Correct the download hash.
That SHA512 is for 24eb17df2e1245885e72c9d4bbb0a0f69f0700f2, which was 0.4.1, not 0c6681e465c9cc7b1fbb60778ba1eaa61ab01a14 which is 0.4.2.
This was probably just done wrong originally in #27240