VSTHRD114: Handle delegate and local functions #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests fail. We need to get these fixed.
|
Oops I forgot to update the code-fix provider. I'll work on it! |
Evangelink
commented
May 4, 2020
...rosoft.VisualStudio.Threading.Analyzers.Tests/VSTHRD114AvoidReturningNullTaskCodeFixTests.cs
Show resolved
Hide resolved
|
I was so close to it!!!! Thanks for the changes @AArnott |
Evangelink
commented
May 4, 2020
| ILocalFunctionOperation localFunction => localFunction.Symbol, | ||
| IAnonymousFunctionOperation anonymousFunction => anonymousFunction.Symbol, | ||
|
|
||
| // Block parent is the method declaration, for vbnet this means a null parent but for C# it's a IMethodBodyOperation |
There was a problem hiding this comment.
🤔 I don't know. I'll leave that up to @sharwell.
This required adding a workaround for dotnet/roslyn#43950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618 and based upon #619
Tagging @AArnott