Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AwaitExtensions.ConfigureAwaitForAggregateException extension method #675

Merged

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Sep 15, 2020

This allows awaiting a Task without losing all but the first of the InnerExceptions when it faults.

Besides adding tests for it, I modify an existing test to use it since it was failing with a timeout on occasion and I suspect the reason is found in another of the Task.WhenAll arguments' failures.

@AArnott AArnott self-assigned this Sep 15, 2020
@AArnott AArnott added this to the v16.8 milestone Sep 15, 2020
…ethod

This allows awaiting a `Task` without losing all but the first of the `InnerExceptions` when it faults.

Besides adding tests for it, I modify an existing test to *use* it since it was failing with a timeout on occasion and I suspect the reason is found in another of the `Task.WhenAll` arguments' failures.
@AArnott AArnott force-pushed the addConfigureAwaitForAggregateException branch from 0326567 to c73c797 Compare September 15, 2020 18:55
@AArnott AArnott merged commit 6ec64de into microsoft:master Sep 17, 2020
@AArnott AArnott deleted the addConfigureAwaitForAggregateException branch September 19, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants