Add RBAC permission request flow for NoSQL accounts #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If connecting to a database account using AAD fails because of missing RBAC permissions, we now notify the user with instructions and an option to assign a contributor role for them. If this fails, show an error notification with a link to RBAC instructions.
sevoku
force-pushed
the
dev/sevoku/rbac-user-flow
branch
from
a6a4935
to
14ea12a
Compare
Sometimes the resource tree continously refreshes all expanded nodes and if authentication fails the RBAC notification pops up again and again. With this change we show the notification only once for each account node. Refreshing the parent (resource group) node will create a new instance and show the notification again.
sevoku
force-pushed
the
dev/sevoku/rbac-user-flow
branch
from
14ea12a
to
6f5975c
Compare
sevoku
force-pushed
the
dev/sevoku/rbac-user-flow
branch
from
8d46a25
to
eeeccc9
Compare
In addition leave error handling to parent resources extension.
bk201-
approved these changes
Aug 6, 2024
alexweininger
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If connecting to a database account using AAD fails because of missing RBAC permissions, we now notify the user with instructions and an option to assign a contributor role for them.
If this fails, show an error notification with a link to RBAC instructions:
"Read More" routes the user to https://aka.ms/cosmos-native-rbac