Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signing for .js files #12749

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Add signing for .js files #12749

merged 3 commits into from
Sep 21, 2024

Conversation

sean-mcmanus
Copy link
Collaborator

@sean-mcmanus sean-mcmanus commented Sep 20, 2024

Fixes #12744

This is based on microsoft/vscode-cmake-tools#3573

@sean-mcmanus sean-mcmanus requested a review from a team September 20, 2024 23:11
@bobbrow
Copy link
Member

bobbrow commented Sep 20, 2024

The PR you linked to also has a proj for signing the vsix. Do you plan to add that one as well?

@sean-mcmanus
Copy link
Collaborator Author

The PR you linked to also has a proj for signing the vsix. Do you plan to add that one as well?

Yeah, I'm saving that for a follow up PR tracked by #12725.

@sean-mcmanus sean-mcmanus merged commit 1f83dd7 into main Sep 21, 2024
6 checks passed
@sean-mcmanus sean-mcmanus deleted the seanmcm/signJsFiles branch September 21, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sign the .js files
2 participants