Dynamic debug config info #8861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
reviewed
Feb 14, 2022
| @@ -31,15 +31,15 @@ function isDebugLaunchStr(str: string): boolean { | |||
| * Ensures that the selected configuration's preLaunchTask (if existent) is populated in the user's task.json. | |||
| * Automatically starts debugging for "Build and Debug" configurations. | |||
| */ | |||
| export class QuickPickConfigurationProvider implements vscode.DebugConfigurationProvider { | |||
| private underlyingProvider: CppConfigurationProvider; | |||
| export class CppDebugConfigurationProvider implements vscode.DebugConfigurationProvider { | |||
There was a problem hiding this comment.
Let's not rename all this stuff. Can you change it back?
Naming a class "Underlying" isn't a very helpful choice. "Underlying" only has meaning within the context that it's used. A standalone class is not "underlying" anything.
We shouldn't use the abbreviation dbg in variable names. In general abbreviations should be avoided, but in this case it also causes confusion with the cppdbg debug type which is an actual thing.
There was a problem hiding this comment.
the name underlying is actually currently existing, I removed it in the next PR, in refactoring the code.
bobbrow
reviewed
Feb 14, 2022
…/vscode-cpptools into elrashed/dynamicLaunch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification to "Run and Debug" button in debug panel to make it consistent with our play button:
3.Fixes are added for single-mode file debugging, however it is only working for cl.exe builds and msvc debugger for now
Feature Request: #8773