Skip to content

Commit

Permalink
adopt node 20 in generator & extension, prepare 1.11.0 (#481)
Browse files Browse the repository at this point in the history
* adopt node 20 in generator & extension, prepare 1.11.0

* generated settings.json refers to output as out instead of dist
  • Loading branch information
aeschli committed Jun 14, 2024
1 parent d885e43 commit 9e2ba51
Show file tree
Hide file tree
Showing 7 changed files with 55 additions and 43 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

strategy:
matrix:
node-version: [18.x]
node-version: [18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
3 changes: 3 additions & 0 deletions build/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,15 @@ extends:
- name: Linux
nodeVersions:
- 18.x
- 20.x
- name: MacOS
nodeVersions:
- 18.x
- 20.x
- name: Windows
nodeVersions:
- 18.x
- 20.x

testSteps:
- script: npm i
Expand Down
6 changes: 3 additions & 3 deletions generators/app/dependencyVersions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"dependencies": {
"@types/mocha": "^10.0.6",
"@types/node": "18.x",
"@types/node": "20.x",
"@types/assert": "^1.5.10",
"@typescript-eslint/eslint-plugin": "^7.11.0",
"@typescript-eslint/parser": "^7.11.0",
Expand All @@ -25,14 +25,14 @@
"ts-loader": "^9.5.1",
"vscode-dts": "^0.3.3",
"vscode-notebook-error-overlay": "^1.0.1",
"webpack": "^5.91.0",
"webpack": "^5.92.0",
"util": "^0.12.5",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^5.0.4",
"assert": "^2.1.0",
"process": "^0.11.10",
"npm-run-all": "^4.1.5",
"esbuild": "^0.21.4",
"esbuild": "^0.21.5",
"@esbuild-plugins/node-globals-polyfill": "^0.2.3"
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// Place your settings in this file to overwrite default and user settings.
{
"files.exclude": {
"out": false // set this to true to hide the "out" folder with the compiled JS files
"dist": false // set this to true to hide the "dist" folder with the compiled JS files
},
"search.exclude": {
"out": true // set this to false to include "out" folder in search results
"dist": true // set this to false to include "dist" folder in search results
},
// Turn off tsc task auto detection since we have the necessary tasks as npm scripts
"typescript.tsc.autoDetect": "off"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// Place your settings in this file to overwrite default and user settings.
{
"files.exclude": {
"out": false // set this to true to hide the "out" folder with the compiled JS files
"dist": false // set this to true to hide the "dist" folder with the compiled JS files
},
"search.exclude": {
"out": true // set this to false to include "out" folder in search results
"dist": true // set this to false to include "dist" folder in search results
},
// Turn off tsc task auto detection since we have the necessary tasks as npm scripts
"typescript.tsc.autoDetect": "off"
Expand Down
71 changes: 40 additions & 31 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "generator-code",
"version": "1.10.1",
"version": "1.11.0",
"description": "Yeoman generator for Visual Studio Code extensions.",
"keywords": [
"yeoman-generator",
Expand All @@ -26,7 +26,7 @@
"url": "https://github.com/Microsoft"
},
"engines": {
"node": ">=16.x"
"node": "^18.17.0 || >=20.5.0"
},
"scripts": {
"test": "mocha",
Expand All @@ -44,9 +44,9 @@
},
"devDependencies": {
"@types/mocha": "^10.0.6",
"@types/node": "^16.18.82",
"@types/node": "^18.18.5",
"mocha": "^10.4.0",
"yeoman-environment": "^4.4.0",
"yeoman-environment": "^4.4.1",
"yeoman-test": "^8.3.0"
}
}

0 comments on commit 9e2ba51

Please sign in to comment.