Support exporting jar #271

CsCherrYY · 2020-06-23T07:26:45Z

Add 'getMainMethod' command in jdtls.ext, which will return all the existing main methods of the workspace.

Update function with no params and add plugin.xml

ghost · 2020-06-23T07:26:58Z

All CLA requirements met.

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java

jdneo

LGTM

sync

Support export jar feature.

...xt/com.microsoft.jdtls.ext.core/src/org/eclipse/jdt/internal/jarpackager/JarPackageUtil.java

src/views/exportJarFile.ts

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java

jdneo

As @testforstephen has mentioned, there are several unnecessary files/code in this PR. Please remove them first. Also, remember add license header when you adding a new file.

jdtls.ext/target.target

package.nls.zh.json

src/views/quickPickNode.ts

src/views/projectPickNode.ts

clankill3r · 2020-07-17T07:21:53Z

Hi, this seams great.
Can you briefly explain how this exporting to a jar will work from a user perspective?

CsCherrYY · 2020-07-17T09:22:39Z

Hi, this seams great.
Can you briefly explain how this exporting to a jar will work from a user perspective?

We will put an export jar button on the title of the Java Projects explorer. It will guide you to export your java project into a (runnable) jar with some necessary steps, such as choosing main method and dependencies.

src/exportJarFileCommand.ts

jdneo · 2020-07-27T11:48:44Z

src/exportJarFileCommand.ts

+                    case ExportSteps.ResolveProject: {
+                        projectFolder = await resolveProject(pickSteps, node);
+                        projectUri = Uri.parse(projectFolder);
+                        rootNodes = await Jdtls.getProjects(projectUri.toString());


Is rootNode here meaning a project node?

Not exactly. For maven project as an example, rootNodes is an Array which includes all the modules defined in pom.xml.

submodules are still projects. rootNode is misleading here, what is root? is it workspace root? And what is node? we don't have tree structure here

src/exportJarFileCommand.ts

src/commands.ts

java.view.package.exportJar -> java.view.package.generateJar

src/exportJarFileCommand.ts

src/exportJarSteps/GenerateJarStep.ts

src/exportJarSteps/IStep.ts

src/views/dependencyDataProvider.ts

src/exportJarSteps/ResolveMainMethodStep.ts

src/exportJarFileCommand.ts

jdneo · 2020-07-30T01:55:47Z

src/exportJarSteps/StepGenerateJar.ts

+        }, (progress, token) => {
+            return new Promise<IJarQuickPickItem[]>(async (resolve, reject) => {
+                token.onCancellationRequested(() => {
+                    return reject();


return resolve([])

src/exportJarSteps/StepGenerateJar.ts

src/exportJarFileCommand.ts

jdneo · 2020-07-30T03:21:38Z

src/exportJarFileCommand.ts

+            try {
+                step = await stepMap.get(step).execute(stepMetadata);
+            } catch (err) {
+                if (err === undefined) {


return err ? reject(${err}) : reject()

jdneo · 2020-07-30T03:24:59Z

src/exportJarSteps/GenerateJarExecutor.ts

+        }
+        const disposables: Disposable[] = [];
+        let pickBox: QuickPick<IJarQuickPickItem>;
+        const result = await new Promise<boolean>(async (resolve, reject) => {


try {
} finally {}

1.Fix disposables bugs 2.move stepMap to grobal

src/exportJarFileCommand.ts

jdneo

LGTM

CsCherrYY added 3 commits June 23, 2020 15:05

add getmainmethod command

6a92859

Update ProjectCommand.java

3d85cf2

Update params

1e0333c

Update function with no params and add plugin.xml

jdneo requested changes Jun 23, 2020

View reviewed changes

Update ProjectCommand.java

afea0b1

jdneo requested changes Jun 24, 2020

View reviewed changes

jdneo added this to the 0.10.2 milestone Jun 24, 2020

Update ProjectCommand.java

86b2454

jdneo reviewed Jun 24, 2020

View reviewed changes

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java Outdated Show resolved Hide resolved

jdneo reviewed Jun 24, 2020

View reviewed changes

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java Outdated Show resolved Hide resolved

Update ProjectCommand.java

d461fb2

jdneo requested changes Jun 24, 2020

View reviewed changes

Update ProjectCommand.java

e3884b5

jdneo previously approved these changes Jun 24, 2020

View reviewed changes

jdneo modified the milestones: 0.10.2, 0.11.0 Jul 6, 2020

CsCherrYY added 2 commits July 16, 2020 09:38

Merge pull request #1 from microsoft/master

c1a4446

sync

Export jar

9f819ca

Support export jar feature.

CsCherrYY dismissed jdneo’s stale review via 9f819ca July 16, 2020 03:16

CsCherrYY changed the title ~~Add 'getMainMethod' command~~ Support exporting jar Jul 16, 2020

CsCherrYY added 2 commits July 16, 2020 11:25

Update pom.xml

7c844e1

Update ProjectCommand.java

9b8a612

testforstephen requested changes Jul 16, 2020

View reviewed changes

jdneo requested changes Jul 17, 2020

View reviewed changes

jdtls.ext/target.target Outdated Show resolved Hide resolved

jdtls.ext/target.target Outdated Show resolved Hide resolved

package.nls.zh.json Outdated Show resolved Hide resolved

jdneo reviewed Jul 17, 2020

View reviewed changes

src/views/quickPickNode.ts Outdated Show resolved Hide resolved

src/views/projectPickNode.ts Outdated Show resolved Hide resolved

testforstephen mentioned this pull request Jul 17, 2020

specify output directory in non maven project microsoft/vscode-java-debug#847

Closed

Apply changes

317c840

Apply changes

e5d3fcd

jdneo requested changes Jul 27, 2020

View reviewed changes

CsCherrYY added 4 commits July 27, 2020 21:51

Apply changes

0e8ec92

Update exportJarFileCommand.ts

12af080

Fix classpath bug

b696b10

Rename Variables

636f917

jdneo reviewed Jul 28, 2020

View reviewed changes

src/exportJarFileCommand.ts Outdated Show resolved Hide resolved

src/exportJarFileCommand.ts Outdated Show resolved Hide resolved

Update exportJarFileCommand.ts

b145363

jdneo reviewed Jul 28, 2020

View reviewed changes

CsCherrYY added 3 commits July 28, 2020 15:32

Update exportJarFileCommand.ts

add8555

Update exportJarFileCommand.ts

6da5127

Change back button type

3513237

jdneo reviewed Jul 29, 2020

View reviewed changes

src/commands.ts Show resolved Hide resolved

src/commands.ts Outdated Show resolved Hide resolved

CsCherrYY added 3 commits July 29, 2020 10:15

Update Placeholder message

2744de0

Rename command

22e57a7

java.view.package.exportJar -> java.view.package.generateJar

Divide into steps (debug version)

f3fbd4d

jdneo requested changes Jul 29, 2020

View reviewed changes

Divide process into steps

10f3590

jdneo requested changes Jul 30, 2020

View reviewed changes

src/exportJarFileCommand.ts Outdated Show resolved Hide resolved

src/exportJarFileCommand.ts Outdated Show resolved Hide resolved

jdneo reviewed Jul 30, 2020

View reviewed changes

src/exportJarSteps/StepGenerateJar.ts Outdated Show resolved Hide resolved

src/exportJarSteps/StepGenerateJar.ts Outdated Show resolved Hide resolved

Using a map to record steps

3bfc6dd

jdneo reviewed Jul 30, 2020

View reviewed changes

Apply changes

c31e7c1

1.Fix disposables bugs 2.move stepMap to grobal

jdneo reviewed Jul 30, 2020

View reviewed changes

src/exportJarFileCommand.ts Outdated Show resolved Hide resolved

CsCherrYY added 3 commits July 30, 2020 12:08

Delete unnecessary code

720103a

Delete unnecessary code

8a91a97

Delete unnecessary code fix

1381e33

jdneo approved these changes Jul 30, 2020

View reviewed changes

jdneo merged commit 23afff6 into microsoft:master Jul 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support exporting jar #271

Support exporting jar #271

CsCherrYY commented Jun 23, 2020

ghost commented Jun 23, 2020 •

edited by ghost

Loading

jdneo left a comment

jdneo left a comment

clankill3r commented Jul 17, 2020

CsCherrYY commented Jul 17, 2020

jdneo Jul 27, 2020

CsCherrYY Jul 27, 2020

jdneo Jul 28, 2020

jdneo Jul 30, 2020

jdneo Jul 30, 2020

jdneo Jul 30, 2020

jdneo left a comment

Support exporting jar #271

Support exporting jar #271

Conversation

CsCherrYY commented Jun 23, 2020

ghost commented Jun 23, 2020 • edited by ghost Loading

jdneo left a comment

Choose a reason for hiding this comment

jdneo left a comment

Choose a reason for hiding this comment

clankill3r commented Jul 17, 2020

CsCherrYY commented Jul 17, 2020

jdneo Jul 27, 2020

Choose a reason for hiding this comment

CsCherrYY Jul 27, 2020

Choose a reason for hiding this comment

jdneo Jul 28, 2020

Choose a reason for hiding this comment

jdneo Jul 30, 2020

Choose a reason for hiding this comment

jdneo Jul 30, 2020

Choose a reason for hiding this comment

jdneo Jul 30, 2020

Choose a reason for hiding this comment

jdneo left a comment

Choose a reason for hiding this comment

ghost commented Jun 23, 2020 •

edited by ghost

Loading