Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy to 1.11.0 #311

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Update mypy to 1.11.0 #311

merged 2 commits into from
Aug 1, 2024

Conversation

meghprkh
Copy link
Contributor

@meghprkh meghprkh commented Jul 27, 2024

Please upgrade to mypy v1.11 as it has a lot of new features from the currently used version of 1.8 and will help with devx quite a lot!

The following bash script is being used:

#!/bin/bash

podman pull python:3.8-alpine
podman run -v .:/workspace:rw -i python:3.8-alpine /bin/sh << EOF
#!/bin/sh
python --version
pip install pip-tools
cd /workspace/
pip-compile --generate-hashes --resolver=backtracking --upgrade ./requirements.in
EOF

VERSION=$(cat requirements.txt | grep 'mypy==' | sed 's/[^0-9.]*//g')
sed -i "s/mypy=[0-9.]*/mypy=${VERSION}/g" README.md

This was referenced Jul 27, 2024
karthiknadig
karthiknadig previously approved these changes Jul 29, 2024
@karthiknadig karthiknadig self-assigned this Jul 29, 2024
@karthiknadig karthiknadig added the debt Technical debt or repo cleanup label Jul 29, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the August 2024 milestone Jul 29, 2024
eleanorjboyd
eleanorjboyd previously approved these changes Jul 29, 2024
@karthiknadig
Copy link
Member

@meghprkh Would you be able to address the merge conflicts?

@meghprkh
Copy link
Contributor Author

I have redone #309 so that there is no conflict in #313. Would it be possible to force-push and remove the latest commit and merge #311 and #313 in order? Again extremely sorry for the inconvenience.

@karthiknadig karthiknadig dismissed stale reviews from eleanorjboyd and themself via f47ca3c August 1, 2024 18:09
@karthiknadig karthiknadig enabled auto-merge (squash) August 1, 2024 18:12
@karthiknadig karthiknadig merged commit 97aeeff into microsoft:main Aug 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt or repo cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants