Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usage of setup-node@v3 in push-check #318

Conversation

hamirmahal
Copy link
Contributor

fixes #317.

@@ -111,7 +111,7 @@ jobs:
path: ${{ env.special-working-directory-relative }}

- name: Install Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 is the latest major version at the time of this writing.

@karthiknadig karthiknadig self-requested a review August 23, 2024 17:06
@karthiknadig karthiknadig self-assigned this Aug 23, 2024
@karthiknadig karthiknadig added the debt Technical debt or repo cleanup label Aug 23, 2024
@karthiknadig karthiknadig enabled auto-merge (squash) August 23, 2024 17:07
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 23, 2024
@karthiknadig karthiknadig merged commit 6f2739d into microsoft:main Aug 28, 2024
22 checks passed
@hamirmahal hamirmahal deleted the fix/usage-of-setup-node-v3-in-push-check branch August 28, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt or repo cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push Validation uses actions/setup-node@v3, which uses a deprecated version of Node.js
3 participants