switch setting name to terminal.shellIntegration.enabled

microsoft · Sep 23, 2024 · f69728d · f69728d
1 parent 0dce2a5
commit f69728d
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 4 deletions.
diff --git a/src/client/common/configSettings.ts b/src/client/common/configSettings.ts
@@ -368,6 +368,7 @@ export class PythonSettings implements IPythonSettings {
                   launchArgs: [],
                   activateEnvironment: true,
                   activateEnvInCurrentTerminal: false,
+                  enableShellIntegration: false,
               };
 
         this.REPL = pythonSettings.get<IREPLSettings>('REPL')!;

diff --git a/src/client/common/types.ts b/src/client/common/types.ts
@@ -197,12 +197,12 @@ export interface ITerminalSettings {
     readonly launchArgs: string[];
     readonly activateEnvironment: boolean;
     readonly activateEnvInCurrentTerminal: boolean;
+    readonly enableShellIntegration: boolean;
 }
 
 export interface IREPLSettings {
     readonly enableREPLSmartSend: boolean;
     readonly sendToNativeREPL: boolean;
-    readonly enableShellIntegration: boolean;
 }
 
 export interface IExperiments {

diff --git a/src/client/terminals/pythonStartup.ts b/src/client/terminals/pythonStartup.ts
@@ -8,7 +8,7 @@ import { EXTENSION_ROOT_DIR } from '../constants';
 
 export async function registerPythonStartup(context: ExtensionContext): Promise<void> {
     const config = getConfiguration('python');
-    const pythonrcSetting = config.get<boolean>('REPL.enableShellIntegration');
+    const pythonrcSetting = config.get<boolean>('terminal.shellIntegration.enabled');
 
     if (pythonrcSetting) {
         const storageUri = context.storageUri || context.globalStorageUri;

diff --git a/src/test/terminals/codeExecution/helper.test.ts b/src/test/terminals/codeExecution/helper.test.ts
@@ -116,7 +116,6 @@ suite('Terminal - Code Execution Helper', () => {
                 enableREPLSmartSend: false,
                 REPLSmartSend: false,
                 sendToNativeREPL: false,
-                enableShellIntegration: true,
             }));
         configurationService.setup((x) => x.getSettings(TypeMoq.It.isAny())).returns(() => pythonSettings.object);
         configurationService

diff --git a/src/test/terminals/codeExecution/smartSend.test.ts b/src/test/terminals/codeExecution/smartSend.test.ts
@@ -113,7 +113,6 @@ suite('REPL - Smart Send', () => {
                 enableREPLSmartSend: true,
                 REPLSmartSend: true,
                 sendToNativeREPL: false,
-                enableShellIntegration: true,
             }));
 
         configurationService.setup((x) => x.getSettings(TypeMoq.It.isAny())).returns(() => pythonSettings.object);