Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runInTerminalRequest does not work on Mac OS #250

Closed
DonJayamanne opened this issue Nov 17, 2017 · 1 comment · May be fixed by whitedragon206/vscode-python#3
Closed

runInTerminalRequest does not work on Mac OS #250

DonJayamanne opened this issue Nov 17, 2017 · 1 comment · May be fixed by whitedragon206/vscode-python#3
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Milestone
December 2017

Comments

@DonJayamanne
Copy link

Using vs code infrastructure to run code in an external terminal does not work (microsoft/vscode#38578)

Once the above solution is resolved (or work around identified) we need to implement this in the LocalDebugClient class.
@DonJayamanne DonJayamanne added closed-upstream area-debugging bug Issue identified by VS Code Team member as probable bug labels Nov 17, 2017
@DonJayamanne DonJayamanne mentioned this issue Nov 17, 2017
Closed
@DonJayamanne DonJayamanne added this to the December 2017 milestone Nov 17, 2017
@DonJayamanne DonJayamanne mentioned this issue Nov 17, 2017
Merged
DonJayamanne added a commit that referenced this issue Nov 22, 2017
@DonJayamanne
Fix issues when running without debugging and debugged code terminates (
a6b49d2 
#249)

- Fixes #25, #32, #35, #235, #242 (unable to run without debugging using CTRL+F5)   
- Fixes #191, #158, #24, #136  (error message displayed when debugged code terminates)  
- Fixes #157 (debugger crashes when python program does not launch)
- Fixes #114, #149, #250 (use vscode infrastructure to launch debugger in integrated and external terminals)  
- Fixes #239 Remove prompt added to pause terminal upon program completion
@DonJayamanne
Copy link
Author

Fixed with #249

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
December 2017
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade tmp from 0.0.33 to 0.2.1 whitedragon206/vscode-python
2 participants
@brettcannon @DonJayamanne