Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function argument completion should not include default value #522

Closed
gauss256 opened this issue Jan 3, 2018 · 1 comment
Closed

Function argument completion should not include default value #522

gauss256 opened this issue Jan 3, 2018 · 1 comment
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality

Comments

@gauss256
Copy link

gauss256 commented Jan 3, 2018

Environment data

VS Code version: 1.19.1
Python Extension version: 0.9.1
Python Version: 3.6.3
OS and version: Ubuntu 14.04

Actual behavior

Suppose you have a function with signature foo(bar=None). If you type foo(ba it displays suggestions to complete the argument. If you hit Enter to accept the suggestion it enters bar=None.

Expected behavior

The completion should just be bar= without the default value None. After all, if we wanted the default value we wouldn't be typing bar. We're trying to change bar to something other than its default.

As it is you have to backspace over the default value to replace it.

I flip back and forth between VSCode and Jupyter notebooks a lot. Notebooks just complete with bar= and it is really convenient.

Steps to reproduce:

As above.

@MikhailArkhipov MikhailArkhipov self-assigned this Jan 3, 2018
@MikhailArkhipov MikhailArkhipov added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug labels Jan 3, 2018
@brettcannon brettcannon added awaiting 1-decision feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Jan 3, 2018
@MikhailArkhipov
Copy link

321e204

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants