Introduce per user installation of modules and elevated global install as an option #532
Conversation
| protected abstract getExecutionInfo(moduleName: string, resource?: vscode.Uri): Promise<ExecutionInfo>; | ||
|
|
||
| private async isPathWritableAsync(directoryPath: string): Promise<boolean> { | ||
| const filePath = `${directoryPath}${path.sep}___vscpTest___`; |
There was a problem hiding this comment.
Something to be moved into IFileSystem interface?
There was a problem hiding this comment.
I am a bit concerned that if it is inside FileSystem and uses same file name for all requests (possibly concurrent), it can give false results. To be inside the FS it would need unique names per request.
There was a problem hiding this comment.
Or we generate a random name everytime.
But we can do that the next time this will be used elsewhere.
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
=========================================
- Coverage 56.42% 56.4% -0.02%
=========================================
Files 212 212
Lines 9968 10018 +50
Branches 1755 1762 +7
=========================================
+ Hits 5624 5651 +27
- Misses 4340 4362 +22
- Partials 4 5 +1
Continue to review full report at Codecov.
|
|
Would you mind changing the title so it explained more of what the PR was doing? I assume this has something to do with permission elevation or something? |
MikhailArkhipov
changed the title
|
Lol of course. Not sure where did that come from... Branch name probably |
Fixes #527 #524 #522