Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be able to specify the path to pipenv #978

Closed
brettcannon opened this issue Mar 7, 2018 · 6 comments · Fixed by #3957
Closed

be able to specify the path to pipenv #978

brettcannon opened this issue Mar 7, 2018 · 6 comments · Fixed by #3957
Assignees
@ericsnowcurrently
Labels
feature-request Request for new features or functionality
Milestone
2019, week 1 - Ja...

Comments

@brettcannon
Copy link
Member

As of pypa/pipenv#1474 (in 11.1.2), pipenv added support for -m execution (although there are other issues on Windows currently preventing me from verifying that it works). Once we can verify this works, we can then change our commands to use python -m pipenv and thus work on Windows more easily.
@brettcannon brettcannon added feature-request Request for new features or functionality needs PR and removed feature-extension labels Mar 7, 2018
@techalchemy
Copy link

@brettcannon if we can track the other related issues affecting windows we can try to fast-track those fixes (I am using windows primarily as well) -- just tag me and I can triage

@brettcannon
Copy link
Member Author

@techalchemy pypa/pipenv#1587 is the latest issue I have bumped up against on Windows. And thanks for the offer to help! I'm happy to keep trying until I don't run into any bugs. 😉

techalchemy added a commit to techalchemy/pew that referenced this issue Mar 8, 2018
@techalchemy
Remove dependence on PSUtil
c7a8e5c 
- Use native ctypes for parent process traversal
- Addresses issues raised in pypa/pipenv#1587
  and microsoft/vscode-python#978
- Improves speed on windows
- Allows pipenv to remove vendored psutil which sometimes fails to find
linked python dlls
@techalchemy techalchemy mentioned this issue Mar 8, 2018
Closed
techalchemy added a commit to techalchemy/pew that referenced this issue Mar 8, 2018
@techalchemy
Remove dependence on PSUtil
631041d 
- Use native ctypes for parent process traversal
- Addresses issues raised in pypa/pipenv#1587
  and microsoft/vscode-python#978
- Improves speed on windows
- Allows pipenv to remove vendored psutil which sometimes fails to find
linked python dlls
@brettcannon brettcannon self-assigned this Mar 12, 2018
@brettcannon
Copy link
Member Author

This seems to be working now so we can consider adding support for this.

@brettcannon brettcannon removed their assignment Mar 13, 2018
@brettcannon brettcannon mentioned this issue Mar 26, 2018
Closed
43 tasks
techalchemy added a commit to techalchemy/pew that referenced this issue Mar 27, 2018
@techalchemy
Remove dependence on PSUtil
6d8afa1 
- Use native ctypes for parent process traversal
- Addresses issues raised in pypa/pipenv#1587
  and microsoft/vscode-python#978
- Improves speed on windows
- Allows pipenv to remove vendored psutil which sometimes fails to find
linked python dlls
@brettcannon brettcannon mentioned this issue Mar 29, 2018
Closed
54 tasks
techalchemy added a commit to techalchemy/pew that referenced this issue Apr 20, 2018
@techalchemy
Remove dependence on PSUtil
818ab1e 
- Use native ctypes for parent process traversal
- Addresses issues raised in pypa/pipenv#1587
  and microsoft/vscode-python#978
- Improves speed on windows
- Allows pipenv to remove vendored psutil which sometimes fails to find
linked python dlls
@brettcannon
Copy link
Member Author

And if we choose not to do this then we should provide a setting for specifying the path to pipenv.

@brettcannon brettcannon changed the title Update pipenv support to use -m Update pipenv support to use -m (or be able to specify the path to pipenv) Apr 26, 2018
@brettcannon brettcannon added this to the May 2018 milestone May 8, 2018
@brettcannon brettcannon removed this from the May 2018 milestone May 24, 2018
@brettcannon brettcannon changed the title Update pipenv support to use -m (or be able to specify the path to pipenv) be able to specify the path to pipenv Jun 6, 2018
@l0b0 l0b0 mentioned this issue Aug 22, 2018
Closed
@DonJayamanne DonJayamanne mentioned this issue Jan 2, 2019
Closed
@ericsnowcurrently ericsnowcurrently self-assigned this Jan 9, 2019
@luabud luabud mentioned this issue Jan 10, 2019
Closed
@ericsnowcurrently ericsnowcurrently mentioned this issue Jan 10, 2019
Merged
4 tasks
@ghost ghost removed the needs PR label Jan 11, 2019
ericsnowcurrently added a commit that referenced this issue Jan 11, 2019
@ericsnowcurrently
gh-978: Add python.pipenvPath config setting. (#3957)
26e75fd
@DonJayamanne
Copy link

DonJayamanne commented Jan 11, 2019 •
edited by brettcannon
Loading

@ericsnowcurrently
There are a few issues, with the needed code (or at least one) I must have accidentally approved this when submitting my review comments.

@DonJayamanne
Copy link

DonJayamanne commented Jan 11, 2019 •
edited
Loading

Please check comments in PR
#3957 (comment)

@ericsnowcurrently ericsnowcurrently mentioned this issue Jan 14, 2019
Merged
@DonJayamanne DonJayamanne mentioned this issue Jan 28, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ericsnowcurrently ericsnowcurrently

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
2019, week 1 - Jan Sprint 1
Development

Successfully merging a pull request may close this issue.

gh-978: Add python.pipenvPath config setting. ericsnowcurrently/vscode-python
4 participants
@brettcannon @techalchemy @ericsnowcurrently @DonJayamanne