Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Prospector unit tests and add more tests for linters #1837

Merged
merged 3 commits into from
Jun 4, 2018

Conversation

DonJayamanne
Copy link

Fixes #1836

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@DonJayamanne DonJayamanne changed the title Issue1836 Fix failing Prospector unit tests and add more tests for linters Jun 2, 2018
@codecov
Copy link

codecov bot commented Jun 2, 2018

Codecov Report

Merging #1837 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1837      +/-   ##
==========================================
- Coverage    74.3%   74.27%   -0.04%     
==========================================
  Files         282      282              
  Lines       13191    13191              
  Branches     2371     2371              
==========================================
- Hits         9801     9797       -4     
- Misses       3259     3262       +3     
- Partials      131      132       +1
Impacted Files Coverage Δ
...reter/locators/services/cacheableLocatorService.ts 91.83% <0%> (-4.09%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (-1.32%) ⬇️
src/client/debugger/Main.ts 52.34% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b097c1a...95b4c60. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 48036ff into microsoft:master Jun 4, 2018
@DonJayamanne DonJayamanne deleted the issue1836 branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Prospector CI errors
2 participants