Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the download links of the language server files #2181

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

DonJayamanne
Copy link

Fixes #2180

  • Title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Unit tests & code coverage are not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
  • [n/a] Dependencies are pinned (e.g. "1.2.3", not "^1.2.3")
  • [n/a] package-lock.json has been regenerated if dependencies have changed

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #2181 into master will decrease coverage by 0.37%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2181      +/-   ##
==========================================
- Coverage   79.98%   79.61%   -0.38%     
==========================================
  Files         308      308              
  Lines       14180    14187       +7     
  Branches     2520     2521       +1     
==========================================
- Hits        11342    11295      -47     
- Misses       2826     2880      +54     
  Partials       12       12
Flag Coverage Δ
#MacOS ?
#Windows ?
Impacted Files Coverage Δ
src/client/activation/platformData.ts 84.37% <100%> (+2.89%) ⬆️
src/client/activation/downloader.ts 35.36% <50%> (+10.36%) ⬆️
src/client/common/platform/registry.ts 40.42% <0%> (-51.07%) ⬇️
src/client/common/platform/pathUtils.ts 66.66% <0%> (-33.34%) ⬇️
src/client/common/utils.ts 51.51% <0%> (-21.22%) ⬇️
src/client/common/platform/serviceRegistry.ts 88.88% <0%> (-11.12%) ⬇️
src/client/common/platform/platformService.ts 84.21% <0%> (-5.27%) ⬇️
src/client/common/process/pythonProcess.ts 88.63% <0%> (-4.55%) ⬇️
src/client/interpreter/locators/index.ts 91.48% <0%> (-4.26%) ⬇️
src/client/refactor/proxy.ts 81.05% <0%> (-3.16%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18631e...863c563. Read the comment docs.

@brettcannon brettcannon merged commit 5f7a029 into microsoft:master Jul 18, 2018
bschley pushed a commit to bschley/vscode-python that referenced this pull request Aug 2, 2018
@DonJayamanne DonJayamanne deleted the issue2180ChangeLinks branch October 2, 2018 22:47
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change logic used to determine download url of language server files
2 participants