Smart Send default value should be true #23074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
feature-request
joyceerhl
approved these changes
Mar 14, 2024
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 5, 2024
Forgot to set default value to true here: microsoft/vscode-python#23067 It was true before removing experiment code since we had experiment to 100%, which effectively overrode the smart send setting value to True.
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 8, 2024
Forgot to set default value to true here: microsoft/vscode-python#23067 It was true before removing experiment code since we had experiment to 100%, which effectively overrode the smart send setting value to True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to set default value to true here: #23067
It was true before removing experiment code since we had experiment to 100%, which effectively overrode the smart send setting value to True.