Ensure native locator is included in the VSIX when built #23476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
reviewed
May 24, 2024
.github/workflows/build.yml
Outdated
| target: aarch64-pc-windows-msvc | ||
| vsix-target: win32-arm64 | ||
| - os: ubuntu-latest | ||
| target: x86_64-unknown-linux-gnu |
There was a problem hiding this comment.
You will want to either:
- Use the musl target on all Linux environments, or
- Ensure you're using a glibc version matching the one we use for VS Code; (e.g. by using a sysroot); by default you'll build with a binary that requires the glibc version of whatever the build machine happens to have
There was a problem hiding this comment.
I see. will make a switch
connor4312
approved these changes
May 24, 2024
DonJayamanne
pushed a commit
that referenced
this pull request
Jun 24, 2024
This ensures that if we run cargo build to build the native code it gets included in the VSIX. For now this is only for the builds for VSIX generated on github, for testing. As this is not ready for published pre-releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if we run cargo build to build the native code it gets included in the VSIX. For now this is only for the builds for VSIX generated on github, for testing. As this is not ready for published pre-releases.