chore: use Linux pools for Alpine builds #23534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
approved these changes
Jun 6, 2024
karthiknadig
pushed a commit
that referenced
this pull request
Jun 7, 2024
I noticed that the pre-release template already has checks for whether the vsceTarget is an Alpine one, and that the current builds are using ubuntu-latest images anyway. As a result, I believe that switching over the Alpine builds to use the 1ES Ubuntu images is the easiest approach to getting the build green. Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=276275&view=results
karthiknadig
pushed a commit
that referenced
this pull request
Jun 18, 2024
I noticed that the pre-release template already has checks for whether the vsceTarget is an Alpine one, and that the current builds are using ubuntu-latest images anyway. As a result, I believe that switching over the Alpine builds to use the 1ES Ubuntu images is the easiest approach to getting the build green. Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=276275&view=results
karthiknadig
pushed a commit
that referenced
this pull request
Jun 20, 2024
I noticed that the pre-release template already has checks for whether the vsceTarget is an Alpine one, and that the current builds are using ubuntu-latest images anyway. As a result, I believe that switching over the Alpine builds to use the 1ES Ubuntu images is the easiest approach to getting the build green. Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=276275&view=results
karthiknadig
pushed a commit
that referenced
this pull request
Jun 21, 2024
I noticed that the pre-release template already has checks for whether the vsceTarget is an Alpine one, and that the current builds are using ubuntu-latest images anyway. As a result, I believe that switching over the Alpine builds to use the 1ES Ubuntu images is the easiest approach to getting the build green. Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=276275&view=results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the pre-release template already has checks for whether the vsceTarget is an Alpine one, and that the current builds are using ubuntu-latest images anyway. As a result, I believe that switching over the Alpine builds to use the 1ES Ubuntu images is the easiest approach to getting the build green.
Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=276275&view=results