-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update language server modules to latest release #23623
Conversation
@@ -5,12 +5,11 @@ import { IJupyterExtensionDependencyManager } from '../common/application/types' | |||
import { IDisposableRegistry, IExtensions } from '../common/types'; | |||
import { IServiceContainer } from '../ioc/types'; | |||
import { sendTelemetryEvent } from '../telemetry'; | |||
import { createHidingMiddleware } from './hidingMiddleware'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this update wasn't quite so automatic. The _Window middleware changed its signature. This meant the middleware exported from the jupyter-lsp-middleware npm module would also need to be updated. Given we haven't updated that in 2 years (and I didn't want to go through the hoops to get it published again), I just copied that code here. It was the only thing used from that module.
@@ -108,7 +108,7 @@ async function runPylance( | |||
middleware, | |||
}; | |||
|
|||
const client = new LanguageClient('python', 'Python Language Server', clientOptions, worker); | |||
const client = new LanguageClient('python', 'Python Language Server', worker, clientOptions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order of the arguments changed on this constructor.
Co-authored-by: Erik De Bonte <erikd@microsoft.com>
@debonte for some reason accepting your suggestions requires another review sign off |
This is a prerequisite to fixing this pylance issue: microsoft/pylance-release#5402 --------- Co-authored-by: Erik De Bonte <erikd@microsoft.com>
This is a prerequisite to fixing this pylance issue: microsoft/pylance-release#5402 --------- Co-authored-by: Erik De Bonte <erikd@microsoft.com>
This is a prerequisite to fixing this pylance issue: microsoft/pylance-release#5402