Include Python Language Server version in survey #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
approved these changes
Sep 20, 2018
| @@ -119,7 +122,8 @@ export class LanguageServerSurveyBanner implements IPythonExtensionBanner { | |||
|
|
|||
| public async launchSurvey(): Promise<void> { | |||
| const launchCounter = await this.getPythonLSLaunchCounter(); | |||
| this.browserService.launch(`https://www.research.net/r/LJZV9BZ?n=${launchCounter}`); | |||
| const lsVersion = await this.getPythonLSVersion(); | |||
| this.browserService.launch(`https://www.research.net/r/LJZV9BZ?n=${launchCounter}&v=${lsVersion}`); | |||
There was a problem hiding this comment.
You might want to escape the query string argument using encodeUriComponent
DonJayamanne
approved these changes
Sep 20, 2018
d3r3kk
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2630
Any new/changed dependencies inpackage.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)