Remove test specific code, ensure black supports paths relative to home #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3r3kk
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
@ericsnowcurrently Check this out on how to make mocked classes more testable, I know I learned something.
|
|
||
| // tslint:disable-next-line:max-func-body-length | ||
| suite('Python Settings', () => { | ||
| let config: TypeMoq.IMock<WorkspaceConfiguration>; | ||
| let expected: PythonSettings; | ||
| let settings: PythonSettings; | ||
| const CustomPythonSettings = class extends PythonSettings { |
There was a problem hiding this comment.
Ok, I see how this works.
Mock out the members of the class you want to test when they are unnecessary for the test you are running.
DonJayamanne
force-pushed
the
issue2274BlackPath
branch
2 times, most recently
from
4ec005d
to
96da10e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2274
For #2678
package.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)