Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the Python system install balloon message #2869

Merged
merged 2 commits into from
Oct 17, 2018

Conversation

joe-graham
Copy link

@joe-graham joe-graham commented Oct 11, 2018

For #2868

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joe-graham
Please could you create a news entry file that summarizes the changes and do remember to thank your self for the changes.

@msftclas
Copy link

msftclas commented Oct 17, 2018

CLA assistant check
All CLA requirements met.

@brettcannon brettcannon merged commit 55a8f51 into microsoft:master Oct 17, 2018
@brettcannon
Copy link
Member

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants