Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the error code placed in beginning of the message #2872

Closed
wants to merge 1 commit into from

Conversation

naflymim
Copy link

@naflymim naflymim commented Oct 12, 2018

For #2815

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Please could you create a news entry file that summarizes the changes and do remember to thank your self in the file.
See here for more info.
https://github.com/Microsoft/vscode-python/tree/master/news

@brettcannon brettcannon changed the title Remove the error code placed in beginning of the message - #2815 Remove the error code placed in beginning of the message Oct 16, 2018
naflymim added a commit to naflymim/vscode-python that referenced this pull request Oct 17, 2018
@naflymim
Copy link
Author

naflymim commented Oct 17, 2018

I have added a news entry file and made the PR. Thanks.

@brettcannon
Copy link
Member

@naflymim what Don was requesting was the news entry be added to this PR so it's a single change.

@brettcannon brettcannon mentioned this pull request Oct 17, 2018
5 tasks
@naflymim naflymim closed this Oct 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants