Add YAML build scripts that mimic the current PR validation build #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested changes
Nov 21, 2018
There was a problem hiding this comment.
We also need to add support for building and uploading extension from the Release branch.
Today we have a task in Travis that does that.
So we need need:
- Run CI on Master branch
- Upload extension built from master branch into blob store (same place everytime)
- We can't have the version number, etc. Cuz it changes, and users won't be able to download the vsix, and it's just painful and unnecessary.
- If you want, you can have both, but we need to have a file name that doesn't change (so that the link can be hardcoded)
- Run CI on Release branch
- Upload extension built from release branch into blob store
- Again, must not contain version information in file name, as is done today.
Fix for microsoft#3350 - Definition mimics the current PR-validation build closely
- This is for interim artifacts only, so everything should be fine.
- Templates that contain jobs can specify their parameters. - Templates containing jobs respect overrides of their parameters - Templates that contain only steps do not behave like job templates! - test-phase is steps template, and its parameters are specified in the master only.
|
The scope for this PR is to get us to 1:1 between our current PR validation CI process and our new YAML-based process. From there, we can add/enhance as we wish (and do so as part of our feature work which will be very useful). TODO after this PR:
|
- use gulp prePublishNonBundle to build bits - ptvsd install has changed to use the latest from PyPI but only one implementation
DonJayamanne
approved these changes
Nov 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3350
Definition mimics the current PR-validation build closely
Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Has a news entry file (remember to thank yourself!)
Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)