Nest subtests under their function in the test explorer. #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4668 +/- ##
======================================
+ Coverage 77% 77% +1%
======================================
Files 447 447
Lines 21484 21534 +50
Branches 3532 3545 +13
======================================
+ Hits 16456 16506 +50
Misses 5024 5024
Partials 4 4
|
DonJayamanne
approved these changes
Mar 11, 2019
ericsnowcurrently
force-pushed
the
test-explorer-nested-subtests
branch
from
7eaaea5
to
9eac943
Compare
DonJayamanne
requested changes
Mar 13, 2019
| @@ -2078,5 +2078,28 @@ export const pytestScenarioData: PytestDiscoveryScenario[] = | |||
| "", | |||
| "======================== no tests ran in 0.36 seconds =========================" | |||
| ] | |||
| }, | |||
| { | |||
| pytest_version_spec: ">= 4.1", | |||
There was a problem hiding this comment.
Aren't we throwing away all of this code, with the merge of the python code for discovery?
If we are, I hope we have similar test scenarios in the python tests
|
@DonJayamanne, You already reviewed this. The only new bit is the tests for TestTreeViewProvider. |
DonJayamanne
approved these changes
Mar 13, 2019
ericsnowcurrently
force-pushed
the
test-explorer-nested-subtests
branch
from
54017df
to
9af296c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(for #4503)
[WARNING} The approach I took is a bit of a hack. Changing the structure of the
Testsdata is a huge undertaking. So I tucked the necessary UI-related data in as a tag-along. :)I'm addressing telemetry in a follow-up PR.
[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)