Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload buillds to azure #534

Merged
merged 206 commits into from
Jan 9, 2018

Conversation

DonJayamanne
Copy link

Fixes #429

octref and others added 30 commits November 3, 2017 13:11
* 'master' of https://github.com/Microsoft/vscode-python:
  Fixes #56 list all environments (#219)
  Fixes #57 Disable activation on debugging (#220)
  Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master:
  Fix typo in README.md (#252)
  Disable linter without workspaces (#241)
* upstream/master:
  Fix feedback service (#246)
  Fix django context initializer (#248)
  disable generation of tags file upon extension load (#264)
* upstream/master:
  Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
  Fixes #22 to Detect anaconda from known locations  (#221)
  Use workspaceFolder token instead of workspaceRoot (#267)
  Fix registry lookup response (#224)
  Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master:
  Fix debugging tests (#304)
* upstream/master:
  Remove jupyter functionality in favor of Jupyter extension (#302)
  Drop Python 2 URLs (#307)
* upstream/master:
  Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
* upstream/master:
  Remove setting linting.lintOnTextChange as it was never implemented (#315)
* upstream/master:
  Fix travis build error (#326)
* upstream/master:
  add new npm deps with improved gulp for dev (#328)
* upstream/master:
  Update version of inversify package (#329)
* upstream/master:
  Document our dev process (#330)
* upstream/master:
  Document contribution to the code along with coding standards (#321)
* upstream/master:
  Add Simplified Chinese translation of commands (#240)
* upstream/master:
  Fix package.json (#347)
* upstream/master:
  #34, #110 - suppress Intellisense in strings and comments (#339)
  Re-factor code python execution framework  (#345)
* upstream/master:
  Fix linters to make use of the new python code execution framework (#360)
  Update the versioning scheme (#356)
  Make npm happy in regards to line endings (#357)
* upstream/master:
  Ensure python path is not set if already set in user settings (#369)
  Use 'an' rather than 'a' before vowel words (#373)
* upstream/master:
  Use new environment variable parser (#362)
@DonJayamanne DonJayamanne reopened this Jan 9, 2018
@DonJayamanne DonJayamanne changed the title WIP - Upload buillds to azure Upload buillds to azure Jan 9, 2018
@codecov
Copy link

codecov bot commented Jan 9, 2018

Codecov Report

Merging #534 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   56.42%   56.21%   -0.22%     
==========================================
  Files         212      212              
  Lines        9968     9975       +7     
  Branches     1755     1753       -2     
==========================================
- Hits         5624     5607      -17     
- Misses       4340     4363      +23     
- Partials        4        5       +1
Impacted Files Coverage Δ
src/client/common/installer/moduleInstaller.ts 50% <0%> (-41.67%) ⬇️
src/client/common/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/debugger/Main.ts 0% <0%> (ø) ⬆️
src/client/common/configSettings.ts 91.39% <0%> (+0.05%) ⬆️
src/client/workspaceSymbols/generator.ts 35.84% <0%> (+1.3%) ⬆️
src/client/common/platform/fileSystem.ts 17.94% <0%> (+2.56%) ⬆️
src/client/common/installer/pythonInstallation.ts 100% <0%> (+4.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4372809...2cbfbe1. Read the comment docs.

@DonJayamanne
Copy link
Author

@brettcannon
Had to create a temporary branch to test the upload works. For some reason protected variables don't seem to work in PRs. Created a branch on MS master branch and it worked like a charm. Didn't bother trying to figure that out, spent too many hours on this thing.

@brettcannon
Copy link
Member

Do you want to tell me privately what to set in the Travis environment variables before you merge so it's ready to go after the merge?

@DonJayamanne DonJayamanne merged commit 7a36147 into microsoft:master Jan 9, 2018
@DonJayamanne DonJayamanne deleted the UploadBuilldsToAzure branch January 10, 2018 18:54
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider releasing preview releases of the extension
3 participants