Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data viewer issues #5405

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Fix data viewer issues #5405

merged 1 commit into from
Apr 22, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Apr 22, 2019

For #5278, #5395

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo self-assigned this Apr 22, 2019
@@ -160,7 +160,8 @@ export namespace DataScience {
export const pythonInteractiveCreateFailed = localize('DataScience.pythonInteractiveCreateFailed', 'Failure to create a \'Python Interactive\' window. Try reinstalling the Python extension.');
export const jupyterGetVariablesExecutionError = localize('DataScience.jupyterGetVariablesExecutionError', 'Failure during variable extraction: \r\n{0}');
export const loadingMessage = localize('DataScience.loadingMessage', 'loading ...');
export const noRowsInDataViewer = localize('DataScience.noRowsInDataViewer', 'Fetching data ...');
export const fetchingDataViewer = localize('DataScience.fetchingDataViewer', 'Fetching data ...');
Copy link
Member

@IanMatthewHuff IanMatthewHuff Apr 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are needed when consuming them in the tsx files. #Resolved

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you're right.


In reply to: 277431565 [](ancestors = 277431565)

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit a49cebf into master Apr 22, 2019
rchiodo added a commit that referenced this pull request Apr 22, 2019
@rchiodo rchiodo deleted the rchiodo/multidimensional branch April 22, 2019 21:39
DonJayamanne added a commit that referenced this pull request Apr 25, 2019
* release: (25 commits)
  Bump version
  remove unexpected trailing commas in JSON files (#5443)
  Fixes to creation of json for Language Server (#5436)
  Update version of Language Server
  Update version (#5435)
  Deprecate travis (#5434)
  Upload vsix to artifacts (#5412)
  Fix the flask app name prompt for launch config. (#5409)
  Reliably end test tasks in Azure Pipelines (#5410)
  fix len error (#5421)
  Fix null cases (#5419)
  Fix sorting of number only lists (#5416)
  add news
  cleanup and functional test
  working first draft
  Fix current cell colors again (#5403)
  Fix data viewer issues (#5405)
  Update 'news' command to directly update the changelog
  Fixes to the test explorer in displaying root (#5383)
  Include pylintrc (#5369)
  ...
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants