Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting of number only lists (#5416) #5418

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Fix sorting of number only lists (#5416) #5418

merged 2 commits into from
Apr 23, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Apr 22, 2019

  • Fix sorting problem with number only lists

For #5414

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo
Fix sorting of number only lists (#5416)
8f4b7d2 
* Fix sorting problem with number only lists

* Add news entry
@rchiodo
Fix null cases (#5419)
73a4d6f
@rchiodo rchiodo merged commit d84b3de into release Apr 23, 2019
@rchiodo rchiodo deleted the rchiodo/release_update_2 branch May 1, 2019 18:22
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rchiodo