Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move shell detectors into separate classes #6401

Merged
merged 15 commits into from
Jul 8, 2019
Merged

Move shell detectors into separate classes #6401

merged 15 commits into from
Jul 8, 2019

Conversation

DonJayamanne
Copy link

For #6050

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [n/a] Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@DonJayamanne DonJayamanne mentioned this pull request Jul 1, 2019
Merged
7 tasks
@DonJayamanne DonJayamanne requested review from karrtikr and removed request for karrtikr July 1, 2019 21:48
@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jul 1, 2019
@DonJayamanne DonJayamanne requested review from ericsnowcurrently and removed request for karrtikr July 2, 2019 17:18
ericsnowcurrently
ericsnowcurrently suggested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I've left a few comments. Also, presumably you moved code from shellDetector.ts to shellDetectors.ts without changing it (likewise with tests).

src/client/common/terminal/shellDetector.ts Outdated Show resolved Hide resolved
src/client/common/terminal/shellDetector.ts Outdated Show resolved Hide resolved
src/client/common/terminal/shellDetectors.ts Outdated Show resolved Hide resolved
src/client/common/terminal/types.ts Outdated Show resolved Hide resolved
src/client/common/terminal/types.ts Outdated Show resolved Hide resolved
src/client/common/terminal/shellDetectors.ts Outdated Show resolved Hide resolved
src/client/common/terminal/shellDetectors.ts Outdated Show resolved Hide resolved
@DonJayamanne
Copy link
Author

@ericsnowcurrently Please re-review

ericsnowcurrently
ericsnowcurrently approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are a couple of open issues still, but I expect you will resolve those before merging.

@ericsnowcurrently
Copy link
Member

Oh, and thanks for making those changes. :)

@DonJayamanne DonJayamanne merged commit 0eb059b into microsoft:master Jul 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
@DonJayamanne DonJayamanne deleted the issue6050 branch September 29, 2019 21:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @ericsnowcurrently