Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to display language server output panel #7461

Merged
merged 3 commits into from
Sep 19, 2019

Conversation

DonJayamanne
Copy link

For #7459

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #7461 into master will increase coverage by 0.31%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7461      +/-   ##
==========================================
+ Coverage   58.23%   58.55%   +0.31%     
==========================================
  Files         494      494              
  Lines       21785    21806      +21     
  Branches     3484     3495      +11     
==========================================
+ Hits        12687    12768      +81     
+ Misses       8309     8246      -63     
- Partials      789      792       +3
Impacted Files Coverage Δ
.../client/activation/languageServer/outputChannel.ts 88.23% <81.81%> (-11.77%) ⬇️
src/client/common/process/logger.ts 86.95% <0%> (-13.05%) ⬇️
src/client/common/liveshare/liveshare.ts 21.42% <0%> (-4.66%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 24.71% <0%> (-0.29%) ⬇️
src/client/common/constants.ts 100% <0%> (ø) ⬆️
src/client/datascience/jupyter/jupyterExecution.ts 57.24% <0%> (+0.09%) ⬆️
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 89.65% <0%> (+13.79%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e4a83...9192070. Read the comment docs.

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also also, I don't see tests for the changes. Please do add the tests. Sorry didn't notice this earlier.

@DonJayamanne
Copy link
Author

Also also, I don't see tests for the changes. Please do add the tests. Sorry didn't notice this earlier

Oh yes, you're right. Oops

@DonJayamanne DonJayamanne merged commit 6647615 into microsoft:master Sep 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
@DonJayamanne DonJayamanne deleted the fixesForUITests branch September 29, 2019 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants