Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch channel commands into activationEvents #7635

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Add switch channel commands into activationEvents #7635

merged 2 commits into from
Sep 27, 2019

Conversation

formulahendry
Copy link
Member

I see some users want to switch daily channel for new features (e.g. Jupyter Notebook native support), but meet with errors: command 'Python.swichToDailyChannel' not found.
So we need to add switch channel commands into activationEvents to avoid this kind of issues.

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #7635 into master will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7635      +/-   ##
=========================================
- Coverage   58.69%     58%   -0.69%     
=========================================
  Files         493     493              
  Lines       21995   21640     -355     
  Branches     3533    3528       -5     
=========================================
- Hits        12909   12552     -357     
- Misses       8278    8280       +2     
  Partials      808     808
Impacted Files Coverage Δ
...nt/datascience/jupyter/invalidNotebookFileError.ts 0% <0%> (-75%) ⬇️
.../client/datascience/jupyter/jupyterConnectError.ts 0% <0%> (-66.67%) ⬇️
...science/jupyter/jupyterKernelPromiseFailedError.ts 0% <0%> (-50%) ⬇️
...ent/datascience/jupyter/jupyterWaitForIdleError.ts 0% <0%> (-50%) ⬇️
src/client/language/characters.ts 12% <0%> (-21.34%) ⬇️
src/client/testing/codeLenses/main.ts 60% <0%> (-17.78%) ⬇️
src/client/datascience/cellFactory.ts 72.34% <0%> (-17.32%) ⬇️
src/client/constants.ts 75% <0%> (-5%) ⬇️
src/client/providers/providerUtilities.ts 84.61% <0%> (-4.28%) ⬇️
src/client/api.ts 90% <0%> (-2.86%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0e70f...8cd191f. Read the comment docs.

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't harm to add that, thanks @formulahendry .

@karrtikr karrtikr added this to the 2019 - October Sprint 1 milestone Sep 27, 2019
@karrtikr karrtikr merged commit 1764e66 into microsoft:master Sep 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants