Skip to content

Commit

Permalink
Merge pull request #40546 from Yukaii/fix-ios-backspace-ime-composition
Browse files Browse the repository at this point in the history
Fix backspace in IME composition on iOS Safari
  • Loading branch information
rebornix authored May 2, 2018
2 parents ae26c6e + 796f392 commit eedc1f5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/vs/editor/browser/controller/textAreaInput.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ export class TextAreaInput extends Disposable {
this._nextCommand = ReadFromTextArea.Type;

this._register(dom.addStandardDisposableListener(textArea.domNode, 'keydown', (e: IKeyboardEvent) => {
if (this._isDoingComposition && e.keyCode === KeyCode.KEY_IN_COMPOSITION) {
if (this._isDoingComposition &&
(e.keyCode === KeyCode.KEY_IN_COMPOSITION || e.keyCode === KeyCode.Backspace)) {
// Stop propagation for keyDown events if the IME is processing key input
e.stopPropagation();
}
Expand Down

0 comments on commit eedc1f5

Please sign in to comment.