Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we hide the terminal cwd in tab description on Windows? #132797

Closed
Tyriar opened this issue Sep 9, 2021 · 2 comments · Fixed by #133037
Closed

Should we hide the terminal cwd in tab description on Windows? #132797

Tyriar opened this issue Sep 9, 2021 · 2 comments · Fixed by #133037
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues windows VS Code on Windows issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2021

Right now cwd is just the initial directory on Windows, this could be useful in multi-root repos but could confuse and just cause noise in single root repos. The actual solution to this needs some thinking.

@Tyriar Tyriar added polish Cleanup and polish issue terminal Integrated terminal issues windows VS Code on Windows issues labels Sep 9, 2021
@Tyriar Tyriar added this to the September 2021 milestone Sep 9, 2021
@meganrogge
Copy link
Contributor

cwdFolder

create capibilities object returning when process gets created, would return !isWindows
if cwdDetection is false, don't fill in
add note to settings that this won't work for Windows
add workspace folder variable so ppl on windows using multi-root could use that

@meganrogge
Copy link
Contributor

if it's a multi-root workspace, show them all (mention in setting)

meganrogge added a commit that referenced this issue Sep 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal Integrated terminal issues windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Tyriar @meganrogge and others