Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Sticky Scroll #156175

Closed
2 tasks done
aiday-mar opened this issue Jul 25, 2022 · 24 comments
Closed
2 tasks done

Test: Sticky Scroll #156175

aiday-mar opened this issue Jul 25, 2022 · 24 comments

Comments

@aiday-mar
Copy link
Contributor

aiday-mar commented Jul 25, 2022

Refs: #26757

Complexity: 2

Create Issue


It is possible to enable the sticky scroll and see in which class/method/constructor/interface/function you are in. You can also click on the sticky item to jump to the line.

  • Go to the settings and enable sticky scroll under Editor > Sticky Scroll : Enable
  • Open a file (so far I only tested on JavaScript files, so it would be a good idea to test other file types)
  • Scroll the file and check that the beginning lines corresponding to class/method/constructor/interface/function stick to the top of the editor correctly on the scrolling event, and appear and disappear smoothly.
  • Check the redirection on the onclick is correct.

Any feedback is greatly appreciated.

@bpasero
Copy link
Member

bpasero commented Jul 26, 2022

Nice 👍

@andreamah
Copy link
Contributor

Awesome job! This is such a cool feature 😁

@aiday-mar
Copy link
Contributor Author

aiday-mar commented Jul 26, 2022

Thanks! I will be working on solving the bugs.

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 28, 2022

Nice work! I opened a few issues from testing this. I think #156623, #156606, and #156616 should be candidates to fix in this iteration

@MohanVallivedu
Copy link

MohanVallivedu commented Jul 28, 2022

This looks like a cool feature. I cannot find this option Sticky Scroll in my VS Code (version: 1.69.2). How do I find and test this extension/feature?

@gjsjohnmurray
Copy link
Contributor

It's in Insiders (1.70) and is expected to reach the Stable version by the end of next week.

@aiday-mar
Copy link
Contributor Author

Thanks for the feedback! I'll make sure to work on fixing the bugs

@mtsh1000
Copy link

Thanks for this cool feature! I think this should also work for: if, for and switch blocks or even unnamed blocks like just {...} js objects etc.

@Jacobify
Copy link

Jacobify commented Aug 9, 2022

hi there, i just updated my editor , but the sticky scroll does not work on any file i have in my projects ( .js files )
it works on .cs files but not in any .js and .vue file.

for example , if i have a .vue file which contain any javascript code , sticky scroll cannot detect other classes, methods , ... .
and for only javascript files it does not detect anything at all

@danielgroen
Copy link

Also for me! .vue files don't work for me. It got stuck on the <template>

@Jacobify
Copy link

Also for me! .vue files don't work for me. It got stuck on the <template>

same thing for me. thanks for mentioning your problem

@Jacobify
Copy link

@aiday-mar can this issue be rechecked for .vue files too ? so that it works properly ?

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Aug 11, 2022

@Jacobify when the next Insiders appears a few hours from now please re-check your case. If the problem remains I suggest you open a new issue (ideally via the Report Issue option on the Help menu) and paste into it some repro code.

@danielgroen
Copy link

@gjsjohnmurray i still see it hanging on the <template> in the .vue files. I updated my vscode to the newest version but without succes. i'll open a new issue

@gjsjohnmurray
Copy link
Contributor

@danielgroen please confirm that you are testing with 1.71 Insiders, not 1.70.1 Stable.

@danielgroen
Copy link

@gjsjohnmurray confirm! tested on 1.71 insiders

@mattheworris
Copy link

This is an awesome feature.

Any plans to add C++ support?

It works for me in .js files, but not .cpp.
I have VIM key bindings enabled, running on Windows, remote SSH to a linux server, with github co-pilot.

Version: 1.70.1 (user setup)
Commit: 6d9b74a
Date: 2022-08-10T06:08:33.642Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.19044

@gjsjohnmurray
Copy link
Contributor

@mattheworris which C++ extensions have you installed? You need one that implements DocumentSymbolProvider. Evidence you've got that is that VS Code's Outline view gets populated for your .cpp files.

@mattheworris
Copy link

@gjsjohnmurray I do have Outline view populated for my cpp files. Sticky scroll still works for python and js files.
Here's a list of my extensions for this workspace.

code --list-extensions
Extensions installed on SSH: 10.XXX.XXX.XXX:
ChaunceyKiwi.json-tree-view
cschlosser.doxdocgen
eamodio.gitlens
GitHub.copilot
GitHub.copilot-labs
jeff-hykin.better-cpp-syntax
ms-python.python
ms-python.vscode-pylance
ms-toolsai.jupyter
ms-vscode-remote.remote-containers
ms-vscode-remote.remote-ssh
ms-vscode-remote.remote-wsl
ms-vscode.cmake-tools
ms-vscode.cpptools
ms-vscode.cpptools-extension-pack
ms-vscode.cpptools-themes
twxs.cmake

@gjsjohnmurray
Copy link
Contributor

Please re-test with Insiders edition, which you can safely install alongside the regular edition (aka Stable).

@Jacobify
Copy link

Jacobify commented Aug 14, 2022

Please re-test with Insiders edition, which you can safely install alongside the regular edition (aka Stable). @gjsjohnmurray

i downloaded the insiders edition and i noticed something. As seen below , some times when i am scrolling the upper part of sticky scroll is exactly duplicated.

1401-05-23 13_19_40-index vue - mdm (Workspace) - Visual Studio Code - Insiders

@danielgroen
Copy link

Please re-test with Insiders edition, which you can safely install alongside the regular edition (aka Stable). @gjsjohnmurray

i downloaded the insiders edition and i noticed something. As seen below , some times when i am scrolling the upper part of sticky scroll is exactly duplicated.

1401-05-23 13_19_40-index vue - mdm (Workspace) - Visual Studio Code - Insiders

This is because you have volar and the newer extension installed. If you remove volar it works properly

@Jacobify
Copy link

Please re-test with Insiders edition, which you can safely install alongside the regular edition (aka Stable). @gjsjohnmurray

i downloaded the insiders edition and i noticed something. As seen below , some times when i am scrolling the upper part of sticky scroll is exactly duplicated.
1401-05-23 13_19_40-index vue - mdm (Workspace) - Visual Studio Code - Insiders

This is because you have volar and the newer extension installed. If you remove volar it works properly

you are right , thanks for clearing it for me.

@mattheworris
Copy link

Please re-test with Insiders edition, which you can safely install alongside the regular edition (aka Stable).

Thanks, it is working with Insiders edition.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants