Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky Scroll: Arrow functions assigned to variables not sticking. #156333

Closed
andreamah opened this issue Jul 26, 2022 · 7 comments
Closed

Sticky Scroll: Arrow functions assigned to variables not sticking. #156333

andreamah opened this issue Jul 26, 2022 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll info-needed Issue requires more information from poster verification-found Issue verification failed verified Verification succeeded
Milestone

Comments

@andreamah
Copy link
Contributor

Testing #156175

Within a class, I declared a function like:

  public exampleFunc= () => {
        .....
  };

And it seemed not to stick.

Image from Gyazo

However, I noticed that arrow functions that are part of arguments stick.

ie:

example(e => { .... });

seemed to work. Ideally, this would be consistent.

@aiday-mar aiday-mar added this to the August 2022 milestone Jul 27, 2022
@aiday-mar aiday-mar added the bug Issue identified by VS Code Team member as probable bug label Jul 27, 2022
@Madalosso
Copy link

👍

@aiday-mar
Copy link
Contributor

Thank you for the feedback. This issue should be solved with PR: #157483

The new behavior

sticky-scroll-arrow-func2

@wmelton
Copy link

wmelton commented Aug 19, 2022

Hey @aiday-mar - I see that PR #157483 was merged, but as of today I still see this issue for arrow functions. Am I wrong in assuming that our const splitFloat should be sticky here?
Kapture 2022-08-19 at 11 06 32

Version: 1.70.2 (Universal)
Commit: e4503b3
Date: 2022-08-16T05:36:37.829Z (3 days ago)
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Darwin x64 21.4.0

@aiday-mar
Copy link
Contributor

Hi thanks for the feedback. The change has appeared in the Insiders version of VSCode. You will see it officially in the next stable build which happens only once per month. You may find the Insiders version of VSCode here https://code.visualstudio.com/insiders/.

@meganrogge
Copy link
Contributor

Hey @aiday-mar this is not working for me for this example:

	public logFunc = () => {
		const x = 3;
		console.log(x);
	};

@meganrogge meganrogge added the verification-found Issue verification failed label Aug 23, 2022
@wmelton
Copy link

wmelton commented Aug 24, 2022

Thanks @aiday-mar and great job getting this fixed so quickly! Great feature addition.

@aiday-mar aiday-mar added the info-needed Issue requires more information from poster label Aug 24, 2022
@aiday-mar
Copy link
Contributor

Hi @meganrogge thanks for filing the bug. That's curious, I am running the main code from the vscode repo and I get the following behavior on OSS:

sticky-scroll-issue

@mjbvz mjbvz added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll info-needed Issue requires more information from poster verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants