Refactoring the sticky scroll

[aiday-mar]

Refactoring the sticky scroll, the code is more concise.

[aiday-mar]

There seems to be still an issue with the sticky scroll, I am looking into it.

[aiday-mar]

The issue was the unnecessary deep cloning

[alexdima]

I noticed the following regression:

• open a file with the contents
• fold public getName()

/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/
namespace One {
	namespace Two {
		namespace Three {
			class A {
				public getName() {

				}
				public getAge() {

				}
			}
		}
	}
}

In Insiders, I see that getName() and getAge() become sticky (as expected):

Kapture.2022-08-08.at.13.02.19.mp4

With the proposed changes, getAge() does not become sticky:

Kapture.2022-08-08.at.13.03.50.mp4

I believe this might be caused by only considering the first visible range in the editor i.e. getCandidateStickyLinesIntersecting(this.editor.getVisibleRanges()[0])

[alexdima]

🎉 Looks good!! I just left a few comments.