Stick Scroll sticks python function's decorator line instead of the declaration line

[lephuongbg]

Does this issue occur when all extensions are disabled?: Yes/No

• VS Code Version: 1.70.0
• OS Version: Windows 11

Steps to Reproduce:

1. Enable sticky scroll
2. Scroll through a python function with decorator

The function:

When the view is scrolled, sticky line should show the definition instead of the decorator. This is what it's like currently:

[nicok1]

Thank you for creating this topic. I have the same problem with all kinds of Spring Boot annotations. One function is sometimes also annotated with multiple annotations, which should also be taken into account.

[pxlrbt]

Same for PHP Docblocks or Attributes.

class Kernel extends ConsoleKernel
{
    /**
     * Define the application's command schedule.
     *
     * @param  \Illuminate\Console\Scheduling\Schedule  $schedule
     * @return void
     */
    protected function schedule(Schedule $schedule)
    {

shows

instead of

[IllusionMH]

It this issue specific to language or decorators? If yes, I'll create separate issue

"Similar" problems can be noticed in Java files where sticky scroll picks start of javadoc comment instead of class/method declarations

[pxlrbt]

I don't have any issues with docblocks in JS. But apparently a lot of other langauges.

[IllusionMH]

Looks like same problem with decorators is reproducible in JS/TS, but not with comments (as in Java above)

[RadsammyT]

This also happens with rust doc blocks, either with the triple slash (///) or the usual doc block ( /** */)

/// All elements of the vector are set to a random number from 0 to the length of the vector (Exclusive)
/// # Example
/// ```
/// vec = shuffle(&mut vec).to_vec();
/// ```
fn shuffle(v: &mut Vec<i32>) -> Vec<i32>{
    let test = v.len() as i32;
    for i in 0..v.len() as i32 {
        v[i as usize] = rand::thread_rng().gen_range(0..test);
    }
    return v.to_vec();
}

What is interesting to note is that C++ (and very likely C) is not affected by this.

    /**
     * @brief Returns an int based on user input
     * 
     * @param prompt 
     * @return int 
     */
    int readI32(std::string prompt) {
        int x;
        std::cout << prompt;
        try {
            std::cin >> x;
        } catch(std::exception e) {
            std::cout << "Invalid input" << std::endl;
            return readI32(prompt);
        }
        return x;
    }

[dfarley1]

This is happening in C code where the function declarations are split over multiple lines as well:


(yes I realize I wrote invalid code 🙃 )

[aiday-mar]

Hi thanks for all your feedback. I will be looking into all these issues.

[TheColorRed]

I am seeing this with TypeScript decorators as well, so it looks like it is most/all languages.

[alexdima]

This might be improved if we would have a custom sticky ranges provider. A language server might tweak the results it would return from a sticky ranges provider to exclude decorators/comments/etc. Also related #157165

[alexdima]

Another example for C# from #157293

When using the new Sticky Scroll with a .NET API project, scrolling in a controller will only show any attributes as the "sticky" heading - [ApiController] - [HttpPost], etc.

[paulojcdev]

Hi,
Similar issue happens with AL language,

Sticky:

expected:

procedure:

Thanks for this feature!

[aiday-mar]

Thank you for all the feedback. This should be fixed by #157466 with @DingWeizhe's contribution

New behavior:

[Grueslayer]

@aiday-mar This seems not to be fixed for AL as posted by @paulojcdev in #157180 (comment) some comments before you commited the fix.

[aiday-mar]

Hi thanks for the feedback. Are you using the Insiders VSCode version? If you are on the stable version (which comes out once per month) you will not yet see the change until the next release. If you are on the Insiders version, are you using an extension which provides a language server for AL? The sticky scroll depends on this. If you are, what extension are you using? I will test on my computer.

[Grueslayer]

I’m on insiders. AL comes from MS and uses a language server. https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

[DonJayamanne]

Verified, however I now run into another issue, not sure if its related though #159118