Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that outlineEntryFactory is revised alongside notebookOutlineProvider work #211759

Closed
Yoyokrazy opened this issue May 1, 2024 · 0 comments
Closed

Ensure that outlineEntryFactory is revised alongside notebookOutlineProvider work #211759

Yoyokrazy opened this issue May 1, 2024 · 0 comments
Assignees
@Yoyokrazy
Labels
notebook-toc-outline under-discussion Issue is under discussion for relevance, priority, approach
Milestone
June 2024

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented May 1, 2024 •
edited
Loading

Please do ensure we clean this in next iteration,
I understand this is a quick fix for recovery, but the code is weird, as we're passing in the target as an argument into the method.

Originally posted by @DonJayamanne in #211741 (comment)
@Yoyokrazy Yoyokrazy self-assigned this May 1, 2024
@Yoyokrazy Yoyokrazy added under-discussion Issue is under discussion for relevance, priority, approach notebook-toc-outline labels May 1, 2024
@Yoyokrazy Yoyokrazy added this to the May 2024 milestone May 1, 2024
@Yoyokrazy Yoyokrazy modified the milestones: May 2024, June 2024 May 29, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Yoyokrazy Yoyokrazy

Labels
notebook-toc-outline under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
June 2024
Development

No branches or pull requests
1 participant
@Yoyokrazy