Candidate: Fix nb outline recompute + nb stickyscroll OutlineTarget #211741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| entries.push(new OutlineEntry(index++, NotebookOutlineConstants.NonHeaderOutlineLevel, cell, preview, !!exeState, exeState ? exeState.isPaused : false)); | ||
| } | ||
| // push code cell entry that is a parent of cached symbols, always necessary. filtering done elsewhere. | ||
| entries.push(new OutlineEntry(index++, NotebookOutlineConstants.NonHeaderOutlineLevel, cell, preview, !!exeState, exeState ? exeState.isPaused : false)); |
There was a problem hiding this comment.
@Yoyokrazy
Please do ensure we clean this in next iteration,
I understand this is a quick fix for recovery, but the code is weird, as we're passing in the target as an argument into the method.
There was a problem hiding this comment.
Yep, this will get addressed in the restructuring that we discussed after the notebook sync. It'll need work after the structure of the notebookOutlineProvider changes to reflect the rawModel vs viewModel ideas we have talked about.
edit: issue created that references this comment
DonJayamanne
approved these changes
May 1, 2024
This was referenced May 1, 2024
Yoyokrazy
added a commit
that referenced
this pull request
May 1, 2024
Qadeem411
approved these changes
May 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #211738