Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find all references broken in standalone editor #56160

Closed
alexdima opened this issue Aug 10, 2018 · 1 comment
Closed

Find all references broken in standalone editor #56160

alexdima opened this issue Aug 10, 2018 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Comments

@alexdima
Copy link
Member

alexdima commented Aug 10, 2018 •
edited
Loading

https://microsoft.github.io/monaco-editor/

fyi @isidorn

simpleServices.ts:148 Error: [createInstance] ReferenceWidget depends on UNKNOWN service uriDisplay.
    at InstantiationService._createInstance (instantiationService.ts:88)
    at InstantiationService.createInstance (instantiationService.ts:73)
    at StandaloneReferencesController.ReferencesController.toggleWidget (referencesController.ts:101)
    at ReferenceAction.run (referenceSearch.ts:91)
    at ReferenceAction.EditorAction.runEditorCommand (editorExtensions.ts:218)
    at editorExtensions.ts:165
    at InstantiationService.invokeFunction (instantiationService.ts:57)
    at StandaloneEditor.CodeEditorWidget.invokeWithinContext (codeEditorWidget.ts:331)
    at ReferenceAction.EditorCommand.runCommand (editorExtensions.ts:158)
    at handler (editorExtensions.ts:90)
@vscodebot vscodebot bot added the editor label Aug 10, 2018
@alexdima alexdima self-assigned this Aug 10, 2018
@alexdima alexdima added important Issue identified as high-priority bug Issue identified by VS Code Team member as probable bug labels Aug 10, 2018
alexdima added a commit that referenced this issue Aug 10, 2018
@alexdima
Fixes #56160
c679b8f
@isidorn
Copy link
Contributor

isidorn commented Aug 13, 2018

@alexandrudima appologies for breaking the standalone editor. And thanks for fixing this.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isidorn @alexdima