VSCode doesn't show anything when Marketplace is offline

[davicoradini]

Issue Type: Bug

VS Marketplace is offline right now, when you try to find some extension it does not show anything.
I've tried reinstalling VSCode, removing all files from %user% folder, I've lost so many time before I saw that the marketplace is offline! It should have some error handling at least!

VS Code version: Code 1.26.1 (493869e, 2018-08-16T18:38:57.434Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-3630QM CPU @ 2.40GHz (8 x 2395)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	15.89GB (11.40GB free)
Process Argv	C:\Users\davic\AppData\Local\Programs\Microsoft VS Code\Code.exe
Screen Reader	no
VM	0%

Extensions: none

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• vscode won't open on windows 10 when offline (#57609)
• Allow users to see installed extensions while offline (#55273)
• Can't see installed extensions when offline (#55193)
• Marketplace is offline [workaround found!] (#57851)

[mjbvz]

Marketplace issues are tracked by #57851

Keeping this issue open to track improving the user experience when the marketplace is down

[chpxu]

@mjbvz How about a more useful error message that is returned if it detects it can't connect to the Marketplace like:

Unfortunately, we cannot seem to connect to the Marketplace at this time, please check back later and perhaps add a link to a Marketplace status monitor of some sorts, or integrate it right into the message itself?

EDIT: Assuming that the status is integrated right into the message, there could be additional info like Check your anti-virus isn't blocking connections to the server or Check your internet connection if necessary/relevant

[ramya-rao-a]

@beastdestroyer That is a good idea.

Updated to show We cannot connect to the Extensions Marketplace at this time, please try again later. when the request to connect to the Marketplace fails

Will continue to show the existing No extensions found. when the request is successful, but no results were found indeed.

Additional info from the http request status text will show up in the console (Help -> Toggle Developer Tools -> Console) as before.