Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Copy All' in the search view adds extra CR chars to the copied text. #65348

Closed
inok6743 opened this issue Dec 19, 2018 · 3 comments
Closed

'Copy All' in the search view adds extra CR chars to the copied text. #65348

inok6743 opened this issue Dec 19, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@inok6743
Copy link

inok6743 commented Dec 19, 2018

Issue Type: Bug

  1. Grep something in the search view, right-click and select 'Copy All'.
  2. Create a new file in VS Code and paste the text.
  3. You will see extra blank lines.

I found that:

  • It doesn't always happen.
  • The text in the clipboard has extra CR (0x0D) chars.

clipboard

VS Code version: Code 1.30.1 (dea8705, 2018-12-18T18:12:19.495Z)
OS version: Windows_NT ia32 6.1.7601

System Info
Item Value
CPUs Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz (4 x 2494)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: unavailable_software
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: unavailable_off
Memory (System) 3.25GB (0.36GB free)
Process Argv
Screen Reader no
VM 0%
Extensions: none
@roblourens
Copy link
Member

Can you give an example of a search result where this happened? I haven't seen it. Was it a multiline search and are you sure those characters don't exist in the document?

@roblourens roblourens added the info-needed Issue requires more information from poster label Dec 20, 2018
@inok6743
Copy link
Author

inok6743 commented Dec 20, 2018

For instance, it happend when I searched the source code of FreeImage. (http://downloads.sourceforge.net/freeimage/FreeImage3180.zip)

I saw extra blank lines like these:
blanklines

I'm not sure but it might happen with the files whose line endings are CRLF. In the example above, the line endings of PluginXPM.cpp or PSDParser.cpp are LF unlike the others.

@vscodebot vscodebot bot removed the new release label Dec 23, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues and removed info-needed Issue requires more information from poster labels Oct 10, 2019
@roblourens
Copy link
Member

Is definitely related to the line ending of the files, but I have no clue.

@roblourens roblourens added the help wanted Issues identified as good community contribution opportunities label Oct 10, 2019
@roblourens roblourens added this to the Backlog milestone Oct 27, 2019
@connor4312 connor4312 modified the milestones: Backlog, November 2020 Nov 13, 2020
@connor4312 connor4312 self-assigned this Nov 13, 2020
@roblourens roblourens added the verified Verification succeeded label Dec 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @connor4312 @inok6743 and others