Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #114432: Multiple save dialogs appearing on Windows if Ctrl+S is pressed multiple times #114450

Merged
merged 13 commits into from
Feb 1, 2021
Merged

Fix #114432: Multiple save dialogs appearing on Windows if Ctrl+S is pressed multiple times #114450

merged 13 commits into from
Feb 1, 2021

Commits on Jan 16, 2021

  1. fix multiple save dialogs appearing on Windows when spamming Ctrl+S

    @CameronIrvine
    CameronIrvine committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    436d6bf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into multiple-save-dialogs

    @CameronIrvine
    CameronIrvine committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    00e4d94 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. remove old fix and instead keep track of windows with open dialogs in… 

    … the dialogMainService
    @CameronIrvine
    CameronIrvine committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    4cf0bae View commit details
    Browse the repository at this point in the history

  2. keep initialisation of activeWindowDialogs in constructor

    @CameronIrvine
    CameronIrvine committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    0124bbb View commit details
    Browse the repository at this point in the history

  3. remove unused variable

    @CameronIrvine
    CameronIrvine committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    30b0b78 View commit details
    Browse the repository at this point in the history

  4. some changes

    @bpasero
    bpasero committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    0ba4635 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. queue dialogs based on hash of options

    @CameronIrvine
    CameronIrvine committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    67a9db4 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2021

  1. simplify structure, fix comment typo

    @CameronIrvine
    CameronIrvine committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    2089a8a View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
    @CameronIrvine @bpasero
    CameronIrvine and bpasero authored Jan 30, 2021
    Configuration menu
    Copy the full SHA
    81922a7 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary async/await for aquireFileDialogLock method

    @CameronIrvine
    CameronIrvine committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    1e9e036 View commit details
    Browse the repository at this point in the history

  3. don't acquire file dialog lock for message boxes

    @CameronIrvine
    CameronIrvine committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    7106e19 View commit details
    Browse the repository at this point in the history

  4. use MessageBoxReturnValue | SaveDialogReturnValue | OpenDialogReturnV… 

    …alue instead of any type for getWindowDialogQueue
    @CameronIrvine
    CameronIrvine committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    ae5d9e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
    @CameronIrvine @bpasero
    CameronIrvine and bpasero authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    cc8806a View commit details
    Browse the repository at this point in the history