Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drop metadata proposal #179918

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Update drop metadata proposal #179918

merged 1 commit into from
Apr 13, 2023

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Apr 13, 2023

  • Makes dropMimeTypes required
  • Prefix the actual id used internally with the extension id
  • Allow wildcard mime types, such as image/*

- Makes `dropMimeTypes` required
- Prefix the actual `id` used internally with the extension id
- Allow wildcard mime types, such as `image/*`
@mjbvz mjbvz self-assigned this Apr 13, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the April 2023 milestone Apr 13, 2023
@mjbvz mjbvz enabled auto-merge (squash) April 13, 2023 21:33
@mjbvz mjbvz merged commit 739b93c into microsoft:main Apr 13, 2023
/**
* Check if this data transfer contains data for a given mime type.
*
* This uses exact matching and does support wildcards.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "does not" here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants