Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding function to modify VM settings #89

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Conversation

pradipd
Copy link
Contributor

@pradipd pradipd commented Mar 16, 2023

This is needed by GPU because we modify the VM settings after we create the VM.

@pradipd pradipd requested a review from madhanrm March 16, 2023 16:03
@pradipd
Copy link
Contributor Author

pradipd commented Mar 16, 2023

Note: the unit test was not compiling. I cleaned it up so it compiles, but it is still failing.
the GPU test fails because it needs to run on gpu machine. that's fine.
but, a few others are failing. I spent a little time debugging but, had to give up.

@pradipd pradipd merged commit 412f058 into master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants